accounts: left pad keybytes-to-encrypt#3032
Merged
Merged
Conversation
fjl
requested changes
Sep 23, 2016
Contributor
fjl
left a comment
fjl
left a comment
There was a problem hiding this comment.
Please add a test that encrypts and decrypts a small key.
Gustav-Simonsson
force-pushed
the
keystore_padding
branch
from
722bf26 to
3ca77c8
Compare
Gustav-Simonsson
force-pushed
the
keystore_padding
branch
from
3ca77c8 to
7cc6b80
Compare
fjl
approved these changes
Sep 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ethcore/parity/issues/2263
This ensures privkey-bytes-to-encrypt are always of length 32, so the resulting ciphertext is also always 32 bytes. Note that this requires no unpadding in decryption, as a decrypted padded byte slice will be interpreted as the same integer by
big.Int.SetBytesIt's backwards compatible as the decryption code is unmodified.